Re: [patch] eventfd/kaio integration fix

From: Andrew Morton
Date: Wed Apr 09 2008 - 15:09:20 EST


On Wed, 9 Apr 2008 11:45:47 -0700 (PDT)
Davide Libenzi <davidel@xxxxxxxxxxxxxxx> wrote:

> Jeff Roberson discovered a race when using kaio eventfd based
> notifications. This patch fixes the race by moving the notification inside
> the spinlocked section of kaio.

Missing information.

What are the consequences of this race, when it occurs?

> The operation is safe since eventfd
> spinlock and kaio one are unrelated.

Yes, it's safe from that perspective.

However with this patch applied, we will no longer run eventfd_signal() if
kiocbIsCancelled(iocb). Convincing is needed, please?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/