Re: [PATCH 0/3] x86: add cpus_scnprintf function v3

From: Bert Wesarg
Date: Wed Apr 09 2008 - 13:51:49 EST


On Tue, Apr 8, 2008 at 8:43 PM, Mike Travis <travis@xxxxxxx> wrote:
> * Cleanup usages of cpumask_scprintf in the following files and add
> another interface to use cpulist_scnprintf where appropriate.

On Mon, Apr 7, 2008 at 8:22 PM, Mike Travis <travis@xxxxxxx> wrote:
> Part of the change is readability, but also looking towards the future
> of 16k/64k/??? # of cpus, the straight mask approach will overflow the
> PAGE_SIZE buffer provided (though some pathological cases will overflow
> the range method as well.) So we'll need some advancement in the format
> of the printout.

Btw, I think you can now push for a deprecation of the 'old' mask
attributes, with the justification you have given above. The other
possibility is to change sysfs to provide bigger attribute buffers
(CCed Greg for this).

Bert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/