Re: [GIT] Please pull NFS client fixes against linux-2.6.25-rc8

From: Trond Myklebust
Date: Wed Apr 09 2008 - 09:12:51 EST



On Wed, 2008-04-09 at 04:24 -0400, Christoph Hellwig wrote:
> > +#ifdef CONFIG_MMU
> > .mmap = nfs_file_mmap,
> > +#else
> > + .mmap = generic_file_mmap,
> > +#endif
>
> This is with almost 100% chance wrong. It might get you a kernel that
> compiles but none where mmap actually works. Just disable mmap on nfs
> for mmu-less systems until someone hacks up a proper mmu-less mmap
> method for nfs.

That is what this does. For the case of no mmu, generic_file_mmap()
compiles into a 'return -ENOSYS;'

--
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/