[PATCH 21/29] parisc: use non-racy method for /proc/pcxl_dma creation

From: Denis V. Lunev
Date: Tue Apr 08 2008 - 07:24:33 EST


Use proc_create() to make sure that ->proc_fops be setup before gluing PDE
to main tree.

Signed-off-by: Denis V. Lunev <den@xxxxxxxxxx>
CC: Kyle McMartin <kyle@xxxxxxxxxxxxxxxx>
CC: Matthew Wilcox <matthew@xxxxxx>
CC: Grant Grundler <grundler@xxxxxxxxxxxxxxxx>
CC: linux-parisc@xxxxxxxxxxxxxxx
---
arch/parisc/kernel/pci-dma.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/arch/parisc/kernel/pci-dma.c b/arch/parisc/kernel/pci-dma.c
index 9448d4e..ccd61b9 100644
--- a/arch/parisc/kernel/pci-dma.c
+++ b/arch/parisc/kernel/pci-dma.c
@@ -397,10 +397,9 @@ pcxl_dma_init(void)
"pcxl_dma_init: Unable to create gsc /proc dir entry\n");
else {
struct proc_dir_entry* ent;
- ent = create_proc_entry("pcxl_dma", 0, proc_gsc_root);
- if (ent)
- ent->proc_fops = &proc_pcxl_dma_ops;
- else
+ ent = proc_create("pcxl_dma", 0, proc_gsc_root,
+ &proc_pcxl_dma_ops);
+ if (!ent)
printk(KERN_WARNING
"pci-dma.c: Unable to create pcxl_dma /proc entry.\n");
}
--
1.5.3.rc5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/