Re: [NFS] Increase size of struct fid raw buffer

[Steven Whitehouse]

Hi,

On Tue, 2008-04-08 at 03:58 -0400, Christoph Hellwig wrote:
> On Tue, Apr 08, 2008 at 08:50:05AM +0100, Steven Whitehouse wrote:
> > I'm happy with that solution, although I'd assumed that the reason this
> > field had a size in the first place was that the NFS people had a plan
> > to use the structure as an allocation entity in the future. Can an NFS
> > developer please confirm/deny this?
> > 
> > If everybody is happy with the plan, then I'll send a patch to make the
> > change as you suggest shortly,
> 
> I've introduce it and I don't plan to use it as allocation entity.  I
> don't quite remember why I sized it either, so it's conceptually fine
> to make it a VLA.  Just do some testing with that variant please.

Then we get this:

In file included from mm/shmem.c:30:
include/linux/exportfs.h:46: error: flexible array member in union
make[1]: *** [mm/shmem.o] Error 1
make: *** [mm] Error 2

but we can have a zero length array though, so I'll test that and send a
patch in due course,

Steve.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/