Re: [PATCH 3/4] pxafb: move parallel LCD timing setup into dedicatefunction

[Andrew Morton]

On Tue, 8 Apr 2008 12:05:16 +0800 "eric miao" <eric.y.miao@xxxxxxxxx> wrote:

> @@ -636,61 +671,31 @@ static int pxafb_activate_var(struct
> fb_var_screeninfo *var,
>  		printk(KERN_ERR "%s: invalid lower_margin %d\n",
>  			fbi->fb.fix.id, var->lower_margin);
>  #endif
> +	/* Update shadow copy atomically */
> +	local_irq_save(flags);

So this code will only ever work on uniprocessor machines?

Is this a safe and reasonable assumption?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/