Re: [PATCH] x86: create array based interface to change page attribute

From: Jesse Barnes
Date: Mon Apr 07 2008 - 17:10:57 EST


On Monday, April 07, 2008 2:02 pm Jesse Barnes wrote:
> On Monday, April 07, 2008 1:56 pm Arjan van de Ven wrote:
> > Jesse Barnes wrote:
> > > Yeah, they're ioremapped now, but that's a problem since with the PAT
> > > patches they'll be mapped hard UC (right now it just happens to work).
> >
> > clearly this needs to use ioremap_wc(), I was assuming nothing else....
> > (code mapping things uncached and then frobbing the MTRR's underneath
> > really shouldn't be allowed to live from 2.6.26 and forward. Esp for the
> > 3D drivers we KNOW that we want _wc so that is a clear case of just
> > fixing the code to do the right thing)
>
> Totally agreed, the AGP code needs to be specific about what it wants...

Err DRM code (but AGP does too).

Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/