Re: [PATCH -mm 2/3] cgroup: simplify init_subsys()
From: Paul Menage
Date: Wed Apr 02 2008 - 06:26:41 EST
On Tue, Apr 1, 2008 at 7:16 PM, Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:
> -
> - /* If this subsystem requested that it be notified with fork
> - * events, we should send it one now for every process in the
> - * system */
> - if (ss->fork) {
> - struct task_struct *g, *p;
> -
> - read_lock(&tasklist_lock);
> - do_each_thread(g, p) {
> - ss->fork(ss, p);
> - } while_each_thread(g, p);
> - read_unlock(&tasklist_lock);
> - }
Should we maybe call ss->fork(ss, &init_task) ? Or just document that
ss->fork() explicitly doesn't get called for init.
Maybe also add some BUG()s to confirm that no other tasks have in fact
been forked by this point?
Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/