Re: + sparc32-delete-bogus-js-rtc-records.patch added to -mm tree

[David Miller]

From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Mon, 31 Mar 2008 16:51:38 -0700

> Subject: sparc32: delete bogus js-rtc records
> From: David Brownell <david-b@xxxxxxxxxxx>
> 
> While looking at the legacy RTC drivers in the drivers/char directory, I
> noticed what looks like bogus entry for SPARC32 systems: JS_RTC, which seems
> to rely on a non-existent js-rtc file.  Just delete it.
> 
> Signed-off-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

It is actually used.  Look at what the Makefile is doing:

> diff -puN drivers/char/Makefile~sparc32-delete-bogus-js-rtc-records drivers/char/Makefile
> --- a/drivers/char/Makefile~sparc32-delete-bogus-js-rtc-records
> +++ a/drivers/char/Makefile
> @@ -109,9 +109,6 @@ obj-$(CONFIG_TCG_TPM)		+= tpm/
>  
>  obj-$(CONFIG_PS3_FLASH)		+= ps3flash.o
>  
> -obj-$(CONFIG_JS_RTC)		+= js-rtc.o
> -js-rtc-y = rtc.o
> -
>  # Files generated that shall be removed upon make clean
>  clean-files := consolemap_deftbl.c defkeymap.c

It's building rtc.c into js-rtc.o, and if CONFIG_JS_RTC is set that
gets linked into the kernel.

Andrew, please drop this one.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/