Re: [PATCH 08/12] xen: add resend_irq_on_evtchn() definition into events.c.

From: Isaku Yamahata
Date: Mon Mar 31 2008 - 05:36:33 EST


On Fri, Mar 28, 2008 at 01:29:54PM -0700, Jeremy Fitzhardinge wrote:
> Isaku Yamahata wrote:
> >Define resend_irq_on_evtchn() which ia64/xen uses.
> >Although it isn't used by current x86/xen code, it's arch generic
> >so that put it into common code.
> >make ipi_to_irq[] visible removing static because
> >ia64/xen needs to access the variable from ia64 specific code
> >
>
> What kind of access? Would it be better to add some accessor functions?
>
> If nothing else, it needs to be prefixed with xen_ if it goes non-static.
>
> (As should resend_irq_on_evtchn(), but I'm less concerned about a name
> collision.)

After revising code, I found the access to ipi_to_irq[] isn't necessary
by calling xen_send_IPI_one(). so dropped the line.

changes from the previous one.
- dropped ipi_to_irq[] change.