Re: Comma at end of enum lists

From: H. Peter Anvin
Date: Sat Mar 29 2008 - 13:20:51 EST


Jacek Luczak wrote:
Hi All,

I've found that in many enum lists, there's a comma at the end, e.g. (arch/x86/kernel/early_printk.c):

enum {
MAGIC1 = 0xBACCD00A,
MAGIC2 = 0xCA110000,
XOPEN = 5,
XWRITE = 4,
};

Just out of curiosity, is there any particular reason here (no word in CodingStyle about that).


Yes, it's so you can add a line without affecting the line before it, making a one-line patch into a two-line patch that's more likely to conflict.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/