Re: [patch] pci: revert "PCI: remove transparent bridge sizing"

[Gary Hade]

On Fri, Mar 28, 2008 at 12:24:02PM -0700, Gary Hade wrote:
> On Fri, Mar 28, 2008 at 01:18:51AM +0300, Ivan Kokshaysky wrote:
> > On Thu, Mar 27, 2008 at 10:12:10AM -0700, Linus Torvalds wrote:
> > > Actually, before we go any further, there might be a less intrusive 
> > > alternative: add just a couple of flags to the resource flags field (we 
> > > still have something like 8 unused bits on 32-bit), and use those to 
> > > implement a generic "resource_alignment()" routine.
> > > 
> > > Two flags would do it:
> > > 
> > >  - IORESOURCE_SIZEALIGN: size indicates alignment (regular PCI device 
> > >    resources)
> > > 
> > >  - IORESOURCE_STARTALIGN: start field is alignment (PCI bus resources 
> > >    during probing)
> > 
> > Sounds good to me. So here we go (completely untested, just for review).
> 
> Ivan, After adding a resource_alignment() prototype to
                 < snip >
> Will now try on one of our servers that I am the most concerned
> about.

Just tried it on an IBM x3850.  No obvious problems or unexpected
messages spotted during/following boot or during/following hotplug
of PCI-X and PCIe cards.

Gary

-- 
Gary Hade
System x Enablement
IBM Linux Technology Center
503-578-4503  IBM T/L: 775-4503
garyhade@xxxxxxxxxx
http://www.ibm.com/linux/ltc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/