Re: [PATCH 3 of 4] sparsemem: reduce i386 PAE section size

From: Jeremy Fitzhardinge
Date: Fri Mar 28 2008 - 14:06:00 EST


Dave Hansen wrote:

Developers should probably learn the tradeoffs before they go start
poking around in code and sending patches. ;)

I don't know any better way of learning the tradeoffs than by poking around and sending patches ;)

BTW, the current 1G sections were picked because all the hardware we
knew of at the time had 512MB dimms that had to be added in pairs. So,
we didn't ever have physical hotplug of less than that.

I guessed it was something like that. Even for my case 1G isn't too bad. It was bad when I was trying to hotplug early and it was having allocation failures in the bootmem allocator, but I think it should be OK now. On the other hand, when you're hotplugging new memory is precisely when you don't want to be allocating lots of new memory...

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/