Re: [PATCH 5/7] omfs: add bitmap routines

[Bob Copeland]

On Thu, Mar 27, 2008 at 11:51 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Thursday 27 March 2008, Bob Copeland wrote:
>
>  > +static int nibblemap[] = {4, 3, 3, 2, 3, 2, 2, 1, 3, 2, 2, 1, 2, 1, 1, 0};
>  > +
>  > +unsigned long omfs_count_free(struct super_block *sb)
>
>  I think it would be helpful to express this using hweight64.

Thanks for the review.

Yes, that would probably be cleaner.  FWIW minix and affs both have
this sort of code too.

-Bob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/