Re: [patch 0/7] vfs: mountinfo (v4)

From: Miklos Szeredi
Date: Thu Mar 27 2008 - 10:43:01 EST


> > Another update that fixes Al's latest comments:
> >
> > - the per-sb options are merged into the fs-specific options
> > - mount source is shown as a separate field (because commas are not
> > escaped within it)
> > - group id checking before allocation/freeing: this one doesn't
> > actually make a difference for the moment (I hope) but Al's variant
> > is cleaner
> > - simplify ID allocation and freeing
> > - dominator renaming
> > - function header comment updating
>
> Is it robust against mounting /dev/$'abc def\x0dghi'
> to ~/mnt/`perl -e 'print "a" x 4050'`?

It is.

> Besides that, I don't like having 'none' as the mount source. Instead, I
> like to e.g. mount proc /proc -t proc, this will put the important
> information into the first column of the mount(1) output, right where I
> start reading.

So do that, this patch doesn't force you to put 'none' in there.

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/