Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and hibernationcallbacks (rev. 4)

From: Alexey Starikovskiy
Date: Wed Mar 26 2008 - 19:27:48 EST


Rafael J. Wysocki wrote:
This is the 4th revision of the patch.
+ * struct pm_noirq_ops - device PM callbacks executed with interrupts disabled
+ *
+ * The following callbacks included in 'struct pm_noirq_ops' are executed with
+ * the nonboot CPUs switched off and with interrupts disabled on the only
+ * functional CPU. They also are executed with the PM core list of devices
+ * locked, so they must NOT unregister any devices.
+ *
+ * @suspend_noirq: Complete the operations of ->suspend() by carrying out any
+ * actions required for suspending the device that need interrupts to be
+ * disabled
IMHO, no need to add _noirq in both struct and struct members.
pm_noirq->suspend_noirq does not look good...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/