Re: [PATCH 1/1] [Blackfin try #2] char driver for Blackfin on-chip OTP memory

From: Sam Ravnborg
Date: Wed Mar 26 2008 - 17:08:11 EST


On Wed, Mar 26, 2008 at 03:14:14PM -0400, Mike Frysinger wrote:
> On Wed, Mar 26, 2008 at 3:09 PM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
> > > > > also, it isnt "broken" in the sense that it "doesnt work" ;)
> > > >
> > > > Gcc simply doesn't allow that, you likely got 2 sections with init.data, with
> > > > and without readonly bit set, which is wrong, and it seems, that on some systems
> > > > (debian) you won't even compile it.
> > >
> > > gcc-4.1.2/binutils-2.17 doesnt have a problem compiling/linking the
> > > code in question. and i imagine i would have noticed a build/link
> > > failure long before testing it on actual hardware.
> >
> > target arch dependent. Try with 64 bit powerpc.
>
> this code appears in drivers that are for Blackfin-specific pieces of
> hardware. it may fail to build on
> some-random-arch-that-isnt-Blackfin, but if it works for Blackfin,
> what do the other arches realistically matter ?
>
> yes, the code will get changed as suggested as it is the right thing
> to do, it just isnt a real problem today.
It is a real problem for build monkeys (like me sometimes) if
an allyesconfig suddenly does not build.

If this driver can be build for other than blackfin I do not
know.

Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/