Re: [patch] pci: revert "PCI: remove transparent bridge sizing"

From: Linus Torvalds
Date: Wed Mar 26 2008 - 16:49:01 EST




On Wed, 26 Mar 2008, Gary Hade wrote:
>
> Could be but without the sizing removal I doubt that the fix I
> was going to propose (see below) would be the same. What I had
> found is that the removal of the transparent bridge sizing was
> leaving the resource record for at least region 7 (IO) of a
> hot-added transparent bridge on the docking station in a state
> that was not palatable with later executed code in pdev_sort_resource().

Ahh, ok, so it was directly caused by simply not sizing and setting up the
bus resources properly.

> Even though the restoration of the transparent bridge sizing
> corrects the problem, pdev_sort_resource() could probably use
> some bulletproofing. I will take a look at this.

Thanks,

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/