Re: [patch] bkl2mtd: cleanup

[Ingo Molnar]

* Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:

> > -		if (ret) {
> > +		if (ret)
> >  			parse_err("illegal erase size");
> > -		}
> >  	}
> 
> BTW, I certainly wouldn't inflict that on patches; at some point in 
> series the body of if may shrink to one line only to get longer in the 
> next patch.  Removing and restoring {} would only add noise.

agreed, we dont enforce it strictly - it is the end result that must be 
clean.

[ OTOH, when i create a patch series i personally always try to make 
  each patch clean, because one never knows when a later patch gets 
  delayed or dropped altogether. ]

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/