Re: [PATCH] firewire: fw-ohci: plug dma memory leak in AR handler

[Stefan Richter]

Jarod Wilson wrote:
> @@ -605,7 +606,7 @@ static void ar_context_tasklet(unsigned long data)
>  			buffer = handle_ar_packet(ctx, buffer);
>  
>  		dma_free_coherent(ohci->card.device, PAGE_SIZE,
> -				  buffer, buffer_bus);
> +				  start, start_bus);
>  		ar_context_add_page(ctx);

On the other hand, why do we free a page + allocate a page?
Why don't we re-initialize and re-add the old page?
--
Stefan Richter
-=====-==--- --== ==-=-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/