Re: [PATCH 01/10] x86_64: Cleanup non-smp usage of cpu maps v2

From: Ingo Molnar
Date: Wed Mar 26 2008 - 02:41:18 EST



* Mike Travis <travis@xxxxxxx> wrote:

> Cleanup references to the early cpu maps for the non-SMP configuration
> and remove some functions called for SMP configurations only.

thanks, applied.

one observation:

> +#ifdef CONFIG_SMP
> extern int x86_cpu_to_node_map_init[];
> extern void *x86_cpu_to_node_map_early_ptr;
> +#else
> +#define x86_cpu_to_node_map_early_ptr NULL
> +#endif

Right now all these early_ptrs are in essence open-coded "early
per-cpu", right? But shouldnt we solve that in a much cleaner way: by
explicitly adding an early-per-cpu types and accessors, and avoid all
that #ifdeffery?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/