Re: [PATCH] list_add corruption in slab.c

From: Oliver Pinter
Date: Tue Mar 25 2008 - 17:27:46 EST


Hi Pekka

this patch for 2.6.22?
(http://repo.or.cz/w/linux-2.6.22.y-op.git)

--8<--
/* 1) create the cache_cache */
INIT_LIST_HEAD(&cache_chain);
list_add(&cache_cache.next, &cache_chain);
cache_cache.colour_off = cache_line_size();
cache_cache.array[smp_processor_id()] = &initarray_cache.cache;
cache_cache.nodelists[node] = &initkmem_list3[CACHE_CACHE];
-->8--
from 2.6.22's slab.c

On 3/25/08, Pekka Enberg <penberg@xxxxxxxxxxxxxx> wrote:
> Hi Daniel,
>
> Daniel Yeisley wrote:
> > I actually saw that initkmem_list reference, but didn't change it since
> > my original patch fixed my list corruption. Anyway, I made the changed
> > and tested it. The system booted fine.
>
> Yeah, but the second change is needed; otherwise we forget to fix up
> some of the bootstrap caches.
>
> > ïSigned-off-by: Dan Yeisley <dan.yeisley@xxxxxxxxxx>
>
> Reviewed-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
>
> Mel, as this change is related to the memoryless node fix that went in
> 2.6.24, any chance you'd give this patch a spin on your machines so we
> can get the fix in 2.6.25 and 2.6.24-stable?
>
> Pekka
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>


--
Thanks,
Oliver
èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸ ¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðà nÆàþY&—