Re: [git pull] vfs patches

From: Linus Torvalds
Date: Tue Mar 25 2008 - 12:06:27 EST




On Tue, 25 Mar 2008, Al Viro wrote:
>
> misc VFS fixes for 2.6.25. Please pull from
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ for-linus

Pulled.

And looking at the diffs, I see sequences like

dget(save.dentry);
mntget(save.mnt);
...
path_put(&save);

which looks very strange compared to the natural sequence:

path_get(&save);
..
path_put(&save);

and yes, I realize the code was just moved (and the reason for the mixing
is that the "path_put()" conversion was done much more aggressively, as
the ordering matters), but I'm bringing this up in the hope somebody has
the energy to clean things like up some day...

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/