Re: [PATCH 2/6] compcache: block device - internal defs

[Will Newton]

On Mon, Mar 24, 2008 at 5:50 PM, Nitin Gupta <nitingupta910@xxxxxxxxx> wrote:
>  >  >  +
>  >  >  +/* Create /proc/compcache? */
>  >  >  +/* If STATS is disabled, this will give minimal compcache info */
>  >  >  +#define CONFIG_COMPCACHE_PROC
>  >  >  +
>  >  >  +#if DEBUG
>  >  >  +#define CC_DEBUG(fmt,arg...) \
>  >  >  +       printk(KERN_DEBUG C fmt,##arg)
>  >  >  +#else
>  >  >  +#define CC_DEBUG(fmt,arg...) NOP
>  >  >  +#endif
>  >
>  >  Have you thought about using pr_debug() for this? It looks like it
>  >  would simplify this file at the cost of a little flexibility.
>  >
>
>  I want to enable/disable this debugging based on DEBUG_COMPCACHE flag.
>  Thats why I added these macros. I will do 'printk(KERN_DEBUG' ->
>  pr_debug

The definition of pr_debug (kernel.h) is already surrounded by #ifdef
DEBUG so it may give you the same behaviour as the CC_DEBUG macro.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/