RE: [PATCH, RFC] Create 'slot' sysfs attributein/sys/devices/system/cpu/cpuN/topology/

From: Luck, Tony
Date: Fri Mar 21 2008 - 20:07:26 EST


+ if (ACPI_SUCCESS(acpi_get_handle(pr->handle, "_SUN", &handle))) {
+ status = acpi_evaluate_object(pr->handle,
+ "_SUN", NULL, &buffer);
+ if (ACPI_FAILURE(status))
+ object.integer.value = -1;
+ } else {
+ object.integer.value = -1;
+ }
+ arch_set_topology_slot(pr->id, object.integer.value);
+
if (!object.processor.pblk_address)
ACPI_DEBUG_PRINT((ACPI_DB_INFO, "No PBLK (NULL address)\n"));
else if (object.processor.pblk_length != 6)

I'm still seeing these messages:

"ACPI: Invalid PBLK length [0]"

for every cpu. Presumably because "object" is a union and when
you did the "object.integer.value = -1;" you scribbled on some bits
that were needed in the subsequent code.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/