[patch 51/76] ioat: fix ack handling, driver must ensure that ack is zero

From: Chris Wright
Date: Fri Mar 21 2008 - 19:05:49 EST


-stable review patch. If anyone has any objections, please let us know.
---------------------

From: Dan Williams <dan.j.williams@xxxxxxxxx>

Initialize 'ack' to zero in case the descriptor has been recycled.

Prevents "kernel BUG at crypto/async_tx/async_xor.c:185!"

Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
Acked-by: Shannon Nelson <shannon.nelson@xxxxxxxxx>
[chrisw@xxxxxxxxxxxx: backport to 2.6.24.3]
Signed-off-by: Chris Wright <chrisw@xxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
---

drivers/dma/ioat_dma.c | 2 ++
1 file changed, 2 insertions(+)

--- a/drivers/dma/ioat_dma.c
+++ b/drivers/dma/ioat_dma.c
@@ -726,6 +726,7 @@ static struct dma_async_tx_descriptor *i

if (new) {
new->len = len;
+ new->async_tx.ack = 0;
return &new->async_tx;
} else
return NULL;
@@ -749,6 +750,7 @@ static struct dma_async_tx_descriptor *i

if (new) {
new->len = len;
+ new->async_tx.ack = 0;
return &new->async_tx;
} else
return NULL;

--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/