Re: [PATCH 0/79] smpboot integration

[Yinghai Lu]

On Fri, Mar 21, 2008 at 2:41 PM, Yinghai Lu <yhlu.kernel@xxxxxxxxx> wrote:
>
> On Fri, Mar 21, 2008 at 1:03 PM, Yinghai Lu <yhlu.kernel@xxxxxxxxx> wrote:
>  >
>  > On Fri, Mar 21, 2008 at 12:55 PM, Ingo Molnar <mingo@xxxxxxx> wrote:
>  >  >
>  >  >  * Yinghai Lu <yhlu.kernel@xxxxxxxxx> wrote:
>  >  >
>  >  >
>  >  > > how to bisect x86.git tree?. it always said it can not bisect seeked
>  >  >  > tree.
>  >  >
>  >  >  ah. Does this work:
>  >  >
>  >  >   git-checkout my-tree x86/latest
>  >  >
>  >  >   git-bisect start
>  >  >   git-bisect good x86/base
>  >  >   git-bisect bad x86/latest
>  >  >
>  >  >  x86/base is the Linus tree that x86.git is based against. You can see
>  >  >  all the x86.git/latest changes by doing:
>  >  >
>  >  >   git-log x86/base..x86/latest
>  >  >
>  >  >         Ingo
>  >  >
>  >
>  >  works. will let you know the result.
>  >
>
>  yhlu@mpk:~/xx/xx/kernel/x86/linux-2.6> git-bisect bad
>  d1c707188ad646c8094cac9afb1738e7d0196ff2 is first bad commit
>  commit d1c707188ad646c8094cac9afb1738e7d0196ff2
>  Author: Glauber de Oliveira Costa <gcosta@xxxxxxxxxx>
>  Date:   Wed Mar 19 14:25:53 2008 -0300
>
>     x86: include mach_apic.h in smpboot_64.c and smpboot.c
>
>     After the inclusion, a lot of files needs fixing for conflicts,
>     some of them in the headers themselves, to accomodate for both
>     i386 and x86_64 versions.
>
>     [ mingo@xxxxxxx: build fix ]
>
>     Signed-off-by: Glauber Costa <gcosta@xxxxxxxxxx>
>     Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
>
>  :040000 040000 19f574e64bb8003bbe984f3a8c1315db969dfdcd
>  6ffe96588c77bc936705599fa110107856201115 M      arch
>  :040000 040000 61269347ad4f384ed85cc87c4f2d004ed94492ac
>  8f5c713da25579a3cdf63db3d4c2f795261d0521 M      include
>  yhlu@mpk:~/xx/xx/kernel/x86/linux-2.6>
>

attached patch fix that.

YH
diff --git a/include/asm-x86/mach-default/mach_apicdef.h b/include/asm-x86/mach-default/mach_apicdef.h
index 7b78275..e4b29ba 100644
--- a/include/asm-x86/mach-default/mach_apicdef.h
+++ b/include/asm-x86/mach-default/mach_apicdef.h
@@ -5,13 +5,12 @@
 
 #ifdef CONFIG_X86_64
 #define	APIC_ID_MASK		(0xFFu<<24)
+#define GET_APIC_ID(x)          (((x)>>24)&0xFFu)
 #define	SET_APIC_ID(x)		(((x)<<24))
 #else
 #define		APIC_ID_MASK		(0xF<<24)
-#endif
-
 static inline unsigned get_apic_id(unsigned long x) 
-{ 
+{
 	unsigned int ver = GET_APIC_VERSION(apic_read(APIC_LVR));
 	if (APIC_XAPIC(ver))
 		return (((x)>>24)&0xFF);
@@ -20,5 +19,6 @@ static inline unsigned get_apic_id(unsigned long x)
 } 
 
 #define		GET_APIC_ID(x)	get_apic_id(x)
+#endif
 
 #endif