Re: r-o bind in nfsd

From: Miklos Szeredi
Date: Fri Mar 21 2008 - 17:17:41 EST


> On Fri, 2008-03-21 at 19:52 +0100, Miklos Szeredi wrote:
> > Traditionally we have syscalls, and nfsd. Both of them want the
> > security checks, and I think nfsd wants the read-only mount checking
> > as well, but I'm not entirely sure. Maybe we can handle that by just
> > making nfsd acquire a write-ref on the mount and keep it while it's
> > exported.
>
> The only question for me would be where the current r/o checks are
> happening (IS_RDONLY()). I generally based my patches on replacing
> those calls.

In may_create()/may_delete() on parent directory. So that one needs
audit of all callers, unless Al can be convinced that moving those
checks into the VFS makes sense.

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/