Re: tick-common.c hack for s390 needed

[Ingo Molnar]

* Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> On Tue, Mar 18, 2008 at 10:31:19AM +0100, Heiko Carstens wrote:
> > Hi Thomas, Ingo,
> > 
> > I'm converting s390 from s390's NO_IDLE_HZ to GENERIC_CLOCKEVENTS and
> > therefore to the generic NO_HZ implementation.
> > One of the problems that need a patch for this is kernel/time/tick-common.c
> > which relies on the irq stuff present in include/linux/irq.h.
> > In particular s390 doesn't have something like irq_set_affinity which
> > causes this build error:
> 
> Generic code must never use linux/irq.h - it's more like asm-generic 
> file predating asm-generic.

agreed.

Heiko, if you remove all these:

 ./time/tick-broadcast.c:#include <linux/irq.h>
 ./time/tick-oneshot.c:#include <linux/irq.h>
 ./time/tick-common.c:#include <linux/irq.h>
 ./hrtimer.c:#include <linux/irq.h>

from kernel/*, do things improve on s390? If yes then please send a 
patch for it and i'll check whether there's any include file dependency 
fallout on x86.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/