Re: [PATCH] Add definitions of USHRT_MAX

[Zhang, Yanmin]

On Thu, 2008-03-20 at 18:51 -0700, Joe Perches wrote:
> On Fri, 2008-03-21 at 09:40 +0800, Zhang, Yanmin wrote:
> > Add definitions of USHRT_MAX and others into kernel. ipc uses it and
> > slub implementation might also use it.
> > +#define USHRT_MAX	((u16)(~0U))
> > +#define SHRT_MAX	((s16)(USHRT_MAX>>1))
> > +#define SHRT_MIN	(-SHRT_MAX - 1)
> 
> Perhaps it's better to use the most common kernel types?
ipc uses USHRT_MAX in a couple of files. Should we keep it consistent?

If ipc wouldn't use it, I would prefer your idea.

> Perhaps U16_MAX, S16_MAX and S16_MIN?
> 
> Don't you need to cast SHRT_MIN/S16_MIN too?
> #define S16_MIN ((s16)(-SHRT_MAX - 1))
No. I simulate INT_MIN. I also tested it by defining a var and didn't get
compilation warning.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/