Re: [PATCH 11/17] ide-tape: remove pipeline-specific code from idetape_setup

[Bartlomiej Zolnierkiewicz]

On Monday 17 March 2008, Borislav Petkov wrote:
> Signed-off-by: Borislav Petkov <petkovbb@xxxxxxxxx>

->max_stages and ->{min,max}_pipeline are later removed in patch #14,
it makes sense to merge both patches together [ as I did ;-) ]

[...]

> -	if (tape->max_stages == 0) {
> -		tape->max_stages   = 1;
> -		tape->min_pipeline = 1;
> -		tape->max_pipeline = 1;
> -	}
> -
> -	t1 = (tape->stage_size * HZ) / (speed * 1000);
> -	tmid = (*(u16 *)&tape->caps[16] * 32 * HZ) / (speed * 125);
> -	tn = (IDETAPE_FIFO_THRESHOLD * tape->stage_size * HZ) / (speed * 1000);
> -
> -	if (tape->max_stages)
> -		t = tn;
> -	else
> -		t = t1;
> +	t = (tape->stage_size * HZ) / (speed * 1000);

tape->max_stages was always > 0 so 't' should use 'tn' not 't1'
(fixed during merge)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/