Re: [patch 6/6] vfs: mountinfo: only show mounts under tasks root

[Miklos Szeredi]

> >  static int show_mountinfo(struct seq_file *m, void *v)
> >  {
> > +	struct proc_mounts *p = m->private;
> > +	size_t count_save = m->count;
> 
> *UGH*.  Do you really need that?  Frankly, in that case I'd rather
> separate the check from __d_path(); unwinds like that are Not Nice(tm).

Agreed.  I did the separate check first, but then there's a window
between the check and __d_path() where the mountpoint might move
outside the root, and trying to prevent that would also add quite a
bit of ugliness.

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/