Re: GIT commit description flag(s)

From: Artem S. Tashkinov
Date: Wed Mar 19 2008 - 18:48:21 EST


I quite agree with you that the description is already there, but such flags could help easily review or grep commits in order to identify your areas of interest.

Even your example has ambiguity: "Wire up new timerfd syscalls" - It's not easy to understand whether this particular commit is a bugfix, or it speeds up things, or the old code which has been cleaned up, etc.

Jan Engelhardt wrote:

On Mar 16 2008 02:35, Artem S. Tashkinov wrote:
It would be nice if [kernel] git commits had a flag [a char] (or a
combination of) describing their main purpose which could be the
following:

bug Fix [F]
Speed up/Performance [S]
Revert [R]
New functionality [N]

Usually you already give the type implicitly in the commit:

dfd347f... HID: fix comment in hid_input_report()
fa331ff... [S390] sclp_vt220: speed up console output for interactive work
d9452e9... [NETPOLL]: Revert two bogus cleanups that broke netconsole.
8727e28... m68k{,nommu}: Wire up new timerfd syscalls
b863ceb... [NET]: Add macvlan driver

So all is well.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/