Re: ide_cd modifies hard_* members of request

From: Boris Petkov
Date: Tue Mar 18 2008 - 07:05:29 EST


(sorry, forgot to cc all)

On Tue, Mar 18, 2008 at 9:54 AM, Nikanth Karthikesan <knikanth@xxxxxxx> wrote:
> Hi
>
> Despite the warning in blkdev.h, that members of struct request starting
> with hard_* are block layer internals, and no driver should touch them,
> the ide_cd driver seems to fiddle around with it.
>
> Is this reqd, or can this be made to work without the need for this?
>
> If this reqd, why not provide a helper function for that in block layer
> itself, may be, with a warning about usage?
>
> Thanks
> Nikanth Karthikesan

Hi,

the code pieces you're referring to are in there since at least the
first git import of the kernel source (i.e. 2005) aka long time so
Bart/Jens should know that...


--
Regards/Gruß,
Boris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/