Re: [PATCH] [IPV6] remove unused parameter (struct sock parameter)from ip6_route_output()

From: YOSHIFUJI Hideaki / 吉藤英明
Date: Tue Mar 18 2008 - 05:14:50 EST


NAK; I have a plan to use it in net-2.6.26 tree.

--yoshfuji

In article <eb3ff54b0803180203h18cda4ceja6ae28033638d338@xxxxxxxxxxxxxx> (at Tue, 18 Mar 2008 11:03:04 +0200), "Rami Rosen" <ramirose@xxxxxxxxx> says:

> Hi,
> This patch removes the struct sock parameter from ip6_route_output();
> looking at the ip6_route_output() implementation in net/ipv6/route.c
> will show immediately that it is not used in this method.
>
> In fact, icmp.c and ip6_output.c are the only places in the kernel
> where the sk (struct sock) parameter passed to ip6_route_output() is not NULL;
> anyhow, as explained above, this parameter is unused; changing
> the ip6_route_output() prototype by omitting the struct sock parameter
> does not break anything.
>
>
> Regards,
> Rami Rosen
>
>
> Signed-off-by: Rami Rosen <ramirose@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/