Re: [PATCH 7/8] Remove current_tick_length()

From: john stultz
Date: Mon Mar 17 2008 - 21:01:19 EST



On Sat, 2008-03-15 at 18:14 +0100, Roman Zippel wrote:
> Hi,
>
> On Sat, 15 Mar 2008, Ray Lee wrote:
>
> > Then make the original function an inline. With -O2 it should compile
> > to exactly the same thing.
>
> This would also defeat John's intention of keeping the value static.

Well, don't mistake me for being fanatical about it. Having the values
be static is cleaner, but if its a real performance issue, then clearly
performance wins.

I do like Ray's suggestion, and think using the inline'd function is
preferred to the raw variable, as it better establishes through use if
nothing else, the read-only nature of the value outside of ntp.

thanks
-john

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/