RE: [PATCH v2] pasemi_dma: Driver for PA Semi PWRficient on-chip DMAengine

[Nelson, Shannon]

>From: Olof Johansson [mailto:olof@xxxxxxxxx] 
>Sent: Sunday, March 16, 2008 2:30 PM
>
>pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine
>
>DMA copy offload driver for PA Semi PWRficient. It uses the
>platform-specific functions to allocate channels, etc.
>
>Signed-off-by: Olof Johansson <olof@xxxxxxxxx>
>
>---
>
>Changes since last post:
>
>* Add DMA_INTERRUPT support and handling of the interrupt flag
>* Fix interrupt handler for above and add tasklet
>* Switch to spin_lock_bh() where possible
>* Remove empty dependency_added() function since it's no longer
>  used in the framework.
>* Fix bug in "ring full" estimation.
>
>Note that this still needs to go on top of the powerpc.git 
>tree due to the
>pasemi_dma.h updates that this driver depends on. I suggest 
>merging this
>through pasemi.git->powerpc.git->linus with an Acked-by from 
>the DMA guys.

Hi Olof,

In the future please copy Maciej as one of "the DMA guys" as he has
taken over ioatdma for me.  Beyond that, one little picky comment
below...


>
>
>-Olof
>
> [...]
> 
>+
>+static unsigned int channels = 4;
>+module_param(channels, uint, S_IRUGO);
>+MODULE_PARM_DESC(channels, "Number of channels for copy 
>(default: 2)");

Is the number of channels defaulting to 2 or 4?

sln

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/