2.6.24.3 broke "make headers_install".

From: Rob Landley
Date: Sun Mar 16 2008 - 18:10:16 EST


On Monday 10 March 2008 22:33:06 Greg KH wrote:
> On Tue, Mar 11, 2008 at 11:13:02AM +0900, Samuel Masham wrote:
> > Hi Stable, Greg, all,
> >
> > Just a quick ping.
> >
> > Still not seeing these on the stable queue? Any issue or am i just
> > looking in the wrong place:-
> >
> > http://www.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git
>
> You're looking in the right place, I'm just slow these days :)
>
> thanks,
>
> greg k-h

Speaking of the stable queue, I just tried 2.6.24.3 and "make headers_install"
now dies with:

make[2]: *** No rule to make target
`/home/landley/firmware/firmware/build/temp-i686/linux/include/linux/if_addrlabel.h',
needed by
`/home/landley/firmware/firmware/build/cross-compiler-i686/include/linux/if_addrlabel.h'.
Stop.

I note that 2.6.24.2 didn't do that.

The problem seems t be this hunk:

diff -ru build.bak/sources/linux/include/linux/Kbuild
build/sources/linux/includ
e/linux/Kbuild
--- build.bak/sources/linux/include/linux/Kbuild 2008-02-10
23:51:11.0000
00000 -0600
+++ build/sources/linux/include/linux/Kbuild 2008-02-25
18:20:20.000000000 -0
600
@@ -217,6 +217,7 @@
unifdef-y += icmp.h
unifdef-y += icmpv6.h
unifdef-y += if_addr.h
+unifdef-y += if_addrlabel.h
unifdef-y += if_arp.h
unifdef-y += if_bridge.h
unifdef-y += if_ec.h

The corresponding if_addrlabel.h file isn't in the 2.6.24.3 tarball, that I
can find...

Rob
--
"One of my most productive days was throwing away 1000 lines of code."
- Ken Thompson.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/