Re: Linux UIO driver cache problem in PowerPC (fix)

[Hans J. Koch]

Am Sun, 16 Mar 2008 03:51:10 +0100
schrieb "Leon Woestenberg" <leon.woestenberg@xxxxxxxxx>:

> Hello,
> 
> On Fri, Mar 14, 2008 at 11:33 AM, Hans J. Koch <hjk@xxxxxxxxxxxxx>
> wrote:
> >  I investigated a bit and found your patch to be correct. I cleaned
> > it up a bit and sent it to Greg and LKML. I added you as author
> > and also took the freedom to add your Signed-off-by.
> >
> Could you elaborate why exactly this is needed, maybe even as a
> comment in the patch?

As far as I understood, the VM_IO flag simply means that the page is
used for IO. On some architectures this automatically means that the
page is not cached, but this is not guaranteed. That's why
pgprot_noncached() exists.

If I misunderstood something or somebody can explain it better, please
let me know.

> 
> It seemed non-trivial enough to rectify adding a comment.

It _is_ trivial. It's just something you don't need every day, and
therefore it's not known to everybody (including me) or not obvious.
But if you look at it:

VM_IO means IO
pgprot_noncached means noncached

What could be more trivial?

Thanks,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/