Re: [PATCH 00/16] (Resend) Use get_personality()

[WANG Cong]

From: Alexey Dobriyan <adobriyan@xxxxxxxxx>
Subject: Re: [PATCH 00/16] (Resend) Use get_personality()
Date: Sat, 23 Feb 2008 11:51:01 +0300
Message-ID: <20080223085101.GC2262@xxxxxxxxxxxxxxxxxxxxxx>

> On Sat, Feb 23, 2008 at 04:14:03PM +0800, WANG Cong wrote:
> > This patchset makes the macro get_personality function alike
> > and teaches code to use get_personality() instead of explicit
> > reference.
> > 
> > [I am sorry if you've received multiple copied of this, since
> >  my git-send-email doesn't work well. ]
> 
> Yes, but why? "current->personality" is way more understandable than
> your macro because task subject to dereference is very visible.

Use get_personality() can hide the task_struct internals a bit.

And I don't think using the macro to access it is less understandable.
Since 'current' won't be NULL, whether the dereference is visible is
not important.

Regards.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/