Re: [patch] suspend/resume self-test

[Ingo Molnar]

* Pavel Machek <pavel@xxxxxx> wrote:

> > Thing is, this will catch not just regressions ... but cases where 
> > STR never worked in the first place.  Video problems, etc.  Also 
> > various system startup races, as in the PCMCIA and MMC/SD/SDIO cases 
> > I noted.
> 
> David is right here. At minimum, s2ram needs acpi_sleep=... options to 
> tell it how to set up the video. That is not issue for you, but it 
> means we should not be doing it by default.

nowhere did i suggest that it should be default-enabled ...

i just suggest the obvious: please make it a trivial, 2 seconds flip of 
a switch, instead of a 60 minutes hunting which i had to do to enable 
the S2RAM self-test: which also meant i had to write a few patches to 
print out what the code does and why it does not work, to finally enable 
this critical test infrastructure.

damn, with that kind of attitude towards people who _want to help_, no 
wonder s2ram still sucks ;-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/