Re: [PATCH v2] mmc: extend ricoh_mmc to support Ricoh RL5c476

From: Pierre Ossman
Date: Thu Feb 07 2008 - 12:20:32 EST


On Thu, 7 Feb 2008 09:20:38 +0100
Frank Seidel <fseidel@xxxxxxx> wrote:

> >
> > Wouldn't it be prudent to have a check that this is indeed a R5C832,
> > and a failure mode if it's none of the two known devices?
>
> Also thought about that, but as far as i can see this cannot happen since
> we only probe for those two devices and deny to continue if anything else
> /those two were not found in the beginning.
>

Can never be too careful though. :)

I've applied the patch for now. Feel free to keep digging and finding some docs for those regs though.

Rgds
Pierre

Attachment: signature.asc
Description: PGP signature