Re: [PATCH] x86_64: fix page table size

From: Ingo Molnar
Date: Thu Feb 07 2008 - 06:55:46 EST



* Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> Yinghai Lu <Yinghai.Lu@xxxxxxx> writes:
> >
> > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
> > index eb376b5..31f0e82 100644
> > --- a/arch/x86/mm/init_64.c
> > +++ b/arch/x86/mm/init_64.c
> > @@ -370,7 +370,7 @@ static void __init find_early_table_space(unsigned long end)
> >
> > puds = (end + PUD_SIZE - 1) >> PUD_SHIFT;
> > tables = round_up(puds * sizeof(pud_t), PAGE_SIZE);
> > - if (direct_gbpages) {
> > + if (!direct_gbpages) {
>
> What tree did you use? The patch I submitted had
>
> if (direct_gbpages == GBP_ON) {

yes, the bug was introduced in your original submission of gbpages.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/