Re: [PATCH] Document randomize_va_space and CONFIG_COMPAT_BRK (wasRe: [PATCH 2/2] ASLR: add possibility for more fine-grained tweaking)

From: Jiri Kosina
Date: Thu Feb 07 2008 - 04:49:57 EST


On Thu, 7 Feb 2008, Ingo Molnar wrote:

> > Still, I think that we want the Documentation/sysctl/kernel.txt part
> > of my patch probably. Updated patch below.
> thanks, applied.

.. and I have just noticed that my patch was by mistake missing signoff.
Could you please add

Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>

to the patch in your tree? Thanks.

> i'm wondering about the following detail: i guess on 64-bit x86 kernels
> we could default to !CONFIG_COMPAT_BRK? In 1997 there was no 64-bit x86.
> Maybe for compat 32-bit binaries we could keep it off, but always do it
> for 64-bit binaries.

That actually makes sense, thanks. I will send you a patch.

Thanks,

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/