Re: partition sysfs OOPS in current GIT

[Greg KH]

On Wed, Feb 06, 2008 at 10:39:44PM -0800, David Miller wrote:
> From: Greg KH <gregkh@xxxxxxx>
> Date: Wed, 6 Feb 2008 22:42:10 -0800
> 
> > On Wed, Feb 06, 2008 at 10:05:44PM -0800, David Miller wrote:
> > > I found the problem, it's the "whole_disk" partition attribute.
> > 
> > I don't understand that code at all, on 2.6.24, what does reading that
> > file give you?  At first glance, I don't see how that file would spit
> > out anything and not give you the same kind of oops.
> > 
> > you are in a maze of kobject pointers, all alike...
> 
> It's supposed to just exist, and be an empty zero length file.
> That's why it's given no ->show method pointer.
> 
> It's existence just means that the partition is a "whole disk"
> partition type.

Can you try this patch to see if it solves the oops, and that the file
is still there and works properly?

thanks,

greg k-h

---
 fs/partitions/check.c |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

--- a/fs/partitions/check.c
+++ b/fs/partitions/check.c
@@ -353,11 +353,9 @@ void add_partition(struct gendisk *disk,
 	partition_sysfs_add_subdir(p);
 	p->dev.uevent_suppress = 0;
 	if (flags & ADDPART_FLAG_WHOLEDISK) {
-		static struct attribute addpartattr = {
-			.name = "whole_disk",
-			.mode = S_IRUSR | S_IRGRP | S_IROTH,
-		};
-		err = sysfs_create_file(&p->dev.kobj, &addpartattr);
+		static DEVICE_ATTR(whole_disk, S_IRUSR | S_IRGRP | S_IROTH,
+				   NULL, NULL);
+		err = device_create_file(&p->dev, &dev_attr_whole_disk);
 	}
 
 	/* suppress uevent if the disk supresses it */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/