Re: partition sysfs OOPS in current GIT

From: Greg KH
Date: Thu Feb 07 2008 - 01:33:45 EST


On Wed, Feb 06, 2008 at 10:05:44PM -0800, David Miller wrote:
> From: Greg KH <gregkh@xxxxxxx>
> Date: Wed, 6 Feb 2008 21:47:38 -0800
>
> > On Wed, Feb 06, 2008 at 08:06:18PM -0800, David Miller wrote:
> > > I redid the bisect to make sure it absolutely was that specific
> > > changeset, and it is.
> >
> > Thanks for doing that, I'll let you know when I have a patch to test.
>
> I found the problem, it's the "whole_disk" partition attribute.
>
> Look in fs/partitions/check.c:add_partition() where it tests the
> ADDPART_FLAG_WHOLEDISK flag.
>
> I think that code block needs to be updated to match the rest of the
> changes in the offending changeset we are discussing.

Ah, great catch. That code just looks wrong.

I'm guessing that you have a partition that is the whole disk? That
would make sense why I and most others haven't seen this yet.

I'll make up a patch...

thanks a lot for still digging into this,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/