Re: [stable] [PATCH][drivers/misc/thinkpad_acpi.c] duplicate testif (level & TP_EC_FAN_FULLSPEED)

From: Greg KH
Date: Thu Feb 07 2008 - 01:04:00 EST


On Thu, Feb 07, 2008 at 12:48:24AM +0100, Roel Kluin wrote:
> Greg KH wrote:
> > On Tue, Feb 05, 2008 at 09:34:54AM +0100, Roel Kluin wrote:
> >> Henrique de Moraes Holschuh wrote:
> >>> On Tue, 05 Feb 2008, Roel Kluin wrote:
> >>>> Roland Dreier wrote:
>
> >>>>> > Note the duplicate test 'if (level & TP_EC_FAN_FULLSPEED)'. should
> >>>>> > this be replaced by
> >>>>>
> >>>>> Actually I suspect one of the two tests should be against TP_EC_FAN_AUTO
> >>>>> (based on the comment).
> >>>> Thanks Roland, for your info
>
> >>> ACK. This needs to be sent to stable as well. I think both 2.6.22 and
> >>> 2.6.23 need this patch.
> >>>
> >> CC stable@xxxxxxxxxx
> >
> > Please send us a real copy of the patch, when it goes into Linus's tree,
> > so we know what to apply, and that it is safe to do so.
>
> It's a oneliner and the patch is from linus' tree.
> ---
> in commit eaa7571b2d1a08873e4bdd8e6db3431df61cd9ad, a safety net for TPEC
> fan control mode was added. Quoting that patch:

I don't see this patch in Linus's tree, I see the patch you are
patching, but not this one :)

Can you tell me the git id of the patch you wish to go into the stable
tree, and send the whole thing to us?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/