Re: [PATCH] at91_mci: minor cleanup

From: Pierre Ossman
Date: Tue Feb 05 2008 - 01:53:01 EST


On Wed, 30 Jan 2008 17:45:48 +0100
Nicolas Ferre <nicolas.ferre@xxxxxxxxx> wrote:

> From: Marc Pignat <marc.pignat@xxxxxxx>
>
> MMC_POWER_ON is a noop, no need to set the power pin again.
>
> Signed-off-by: Marc Pignat <marc.pignat@xxxxxxx>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
> ---

Perhaps also a WARN_ON() or something in the default case to catch bad invokations?

Rgds
Pierre

Attachment: signature.asc
Description: PGP signature