Re: [PATCH] x86: fix compile waring building without CONFIG_SYSCTL

From: Ingo Molnar
Date: Sun Feb 03 2008 - 02:13:29 EST



* Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:

> +#ifdef CONFIG_SYSCTL
> static int unknown_nmi_panic_callback(struct pt_regs *regs, int cpu);
> +#endif

instead of adding another #ifdef, a much cleaner solution would be to
just reorder do_nmi_callback() with unknown_nmi_panic_callback(), and
eliminate the prototype altogether.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/