[PATCH] mxser: fix compile warning building without CONFIG_PCI

From: Li Zefan
Date: Sat Feb 02 2008 - 22:02:00 EST


When build without CONFIG_PIC, got the following warnings:

drivers/char/mxser.c: In function 'mxser_init':
drivers/char/mxser.c:698: warning: unused variable 'devnum'
drivers/char/mxser.c:698: warning: unused variable 'busnum'
drivers/char/mxser.c:697: warning: unused variable 'index'
drivers/char/mxser.c:696: warning: unused variable 'pdev'
drivers/char/mxser.c:695: warning: unused variable 'n'

Signed-off-by: Li Zefan <lizf@xxxxxxxxxxxxxx>
---
drivers/char/mxser.c | 14 ++++++--------
1 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c
index fd0abef..b2cc93d 100644
--- a/drivers/char/mxser.c
+++ b/drivers/char/mxser.c
@@ -692,10 +692,7 @@ static int mxser_get_PCI_conf(int busnum, int devnum, int board_type, struct mxs

static int mxser_init(void)
{
- int i, m, retval, b, n;
- struct pci_dev *pdev = NULL;
- int index;
- unsigned char busnum, devnum;
+ int i, m, retval, b;
struct mxser_hwconf hwconf;

mxvar_sdriver = alloc_tty_driver(MXSER_PORTS + 1);
@@ -834,10 +831,11 @@ static int mxser_init(void)

/* start finding PCI board here */
#ifdef CONFIG_PCI
- n = ARRAY_SIZE(mxser_pcibrds) - 1;
- index = 0;
b = 0;
- while (b < n) {
+ while (b < ARRAY_SIZE(mxser_pcibrds)-1) {
+ unsigned char busnum, devnum;
+ struct pci_dev *pdev;
+
pdev = pci_get_device(mxser_pcibrds[b].vendor,
mxser_pcibrds[b].device, pdev);
if (pdev == NULL) {
@@ -850,7 +848,7 @@ static int mxser_init(void)
printk(KERN_INFO "Found MOXA %s board(BusNo=%d,DevNo=%d)\n",
mxser_brdname[(int) (mxser_pcibrds[b].driver_data) - 1],
busnum, devnum >> 3);
- index++;
+
if (m >= MXSER_BOARDS)
printk(KERN_ERR
"Too many Smartio/Industio family boards find "
--
1.5.4.rc3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/